[dpdk-dev] [EXT] Re: [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux

[Ferruh Yigit]

On 10/15/2021 2:58 PM, Pavan Nikhilesh Bhagavatula wrote:
> 
> 
>> -----Original Message-----
>> From: dev <dev-bounces at dpdk.org> On Behalf Of Ferruh Yigit
>> Sent: Friday, October 15, 2021 4:09 PM
>> To: Pavan Nikhilesh Bhagavatula <pbhagavatula at marvell.com>; Jerin
>> Jacob Kollanukkaran <jerinj at marvell.com>; Maciej Czekaj [C]
>> <mczekaj at marvell.com>
>> Cc: dev at dpdk.org
>> Subject: [EXT] Re: [dpdk-dev] [PATCH v6 1/3] net/thunderx: enable
>> build only on 64-bit Linux
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On 10/14/2021 8:56 PM, pbhagavatula at marvell.com wrote:
>>> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>>>
>>> Since AARCH32 extension is not implemented on thunderx family,
>> only
>>> enable build for 64bit.
>>> Due to Linux kernel AF(Admin function) driver dependency, only
>> enable
>>> build for Linux.
>>>
>>
>> Hi Pavan,
>>
>> Perhaps this patch took more time than it should, but according Jerin's
>> description the problem is SoC can't run 32bit applications.
>>
>> Why do you still mention from the kernel driver dependency? It looks
>> like
>> that dependency is not reason to not compile 32 bit app, am I missing
>> something?
>>
> 
> Since DPDK runs on FreeBSD and Windows and AF driver is absent for those
> We are disabling this driver non-Linux compilations too.
> 

Ah, it doesn't only add 'RTE_ARCH_64' requirement, also reduces the support
to Linux, so commit log makes sense. Thanks.

>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
>>> Acked-by: Jerin Jacob <jerinj at marvell.com>
>>> ---
>>>    v6 Changes:
>>>    - Update commit log to describe why 32bit is not supported.
>>>    v5 Changes:
>>>    - s/fuction/function.
>>>    v4 Changes:
>>>    - Update commit message regarding dependency on AF driver.
>>>
>>>    drivers/net/thunderx/meson.build | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/thunderx/meson.build
>> b/drivers/net/thunderx/meson.build
>>> index 4bbcea7f93..da665bd76f 100644
>>> --- a/drivers/net/thunderx/meson.build
>>> +++ b/drivers/net/thunderx/meson.build
>>> @@ -1,9 +1,9 @@
>>>    # SPDX-License-Identifier: BSD-3-Clause
>>>    # Copyright(c) 2017 Cavium, Inc
>>>
>>> -if is_windows
>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>        build = false
>>> -    reason = 'not supported on Windows'
>>> +    reason = 'only supported on 64-bit Linux'
>>>        subdir_done()
>>>    endif
>>>
>>> --
>>> 2.17.1
>>>
>