[dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated

[Olivier Matz]

Hi Andrew,

On Sat, Oct 16, 2021 at 10:50:50AM +0300, Andrew Rybchenko wrote:
> On 10/15/21 10:24 PM, Olivier Matz wrote:
> > The flags PKT_TX_VLAN_PKT and PKT_TX_QINQ_PKT are
> > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated
> > VLAN flags") (2017). But they were not using the RTE_DEPRECATED
> > macro, because it did not exist at this time. Add it, and replace
> > usage of these flags.
> > 
> > Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> 
> I'd remove these flags completely. 4 years is definitely
> enough. Yes, I realize that because of missing
> RTE_DEPRECATED markup users were not warning on build.

I kept them because David pointed me that these flags are still used by
other projects. Adding an explicit RTE_DEPRECATED() would prevent this,
and... it doesn't bother to add one more year :)

Thank you for the review.