[dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Tue Oct 19 20:07:48 CEST 2021


On 10/19/21 2:55 PM, Ferruh Yigit wrote:
> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote:
>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved
>> right now is a good chance to make a cleanup.
>>
>> No strong opinion, but I think it would be useful for the future.
>>
>> Make be at least some fixes from below could be accepted.
>>
>> Andrew Rybchenko (5):
>>    ethdev: avoid documentation in next lines
>>    ethdev: fix Rx/Tx spelling in just moved structures
>>    ethdev: remove reserved fields from internal structures
>>    ethdev: make device and data structures readable
>>    ethdev: remove full stop after short comments and references
>>
> 
> Overall +1 to these changes, I think this release is the opportunity
> to have changes like this.
> 
> But as far as I can see only new moved code updated in 'ethdev_driver.h',
> why not update whole 'ethdev_driver.h'?

Simply don't want to complicate search by git blame because of cosmetic
changes. No strong opinion, but decided to go this way for now.


More information about the dev mailing list