[dpdk-dev] [PATCH v8 1/3] ethdev: support L2TPv2 and PPP procotol

[Andrew Rybchenko]

On 10/21/21 1:05 PM, Jie Wang wrote:
> Added flow pattern items and header formats of L2TPv2 and PPP.
> 
> Acked-by: Ori Kam <orika at nvidia.com>

Acks should go after Signed-off-by.

> Signed-off-by: Wenjun Wu <wenjun1.wu at intel.com>
> Signed-off-by: Jie Wang <jie1x.wang at intel.com>

with a couple of nits fixed

Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>

[snip]

> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 64ed7f2618..300e99e16b 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h

[snip]

> @@ -1900,6 +1916,55 @@ static const struct rte_flow_item_ethdev rte_flow_item_ethdev_mask = {
>  };
>  #endif
>  
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this structure may change without prior notice

Empty line is required between EXPERIMENTAL and item name.

> + * RTE_FLOW_ITEM_TYPE_L2TPV2
> + *
> + * Matches L2TPv2 Header
> + */
> +struct rte_flow_item_l2tpv2 {
> +	struct rte_l2tpv2_combined_msg_hdr hdr;
> +};
> +
> +/** Default mask for RTE_FLOW_ITEM_TYPE_L2TPV2. */
> +#ifndef __cplusplus
> +static const struct rte_flow_item_l2tpv2 rte_flow_item_l2tpv2_mask = {
> +	/*
> +	 * flags and version bit mask
> +	 * 7 6 5 4 3 2 1 0 7 6 5 4 3 2 1 0
> +	 * T L x x S x O P x x x x V V V V
> +	 */
> +	.hdr = {
> +		.common = {
> +			.flags_version = RTE_BE16(0xcb0f),
> +		},
> +	},
> +};
> +#endif
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this structure may change without prior notice

here too

[snip]