[dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last device
Raslan Darawsheh
rasland at nvidia.com
Thu Oct 21 12:36:01 CEST 2021
Hi,
> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Dmitry Kozlyuk
> Sent: Thursday, October 14, 2021 11:55 AM
> To: dev at dpdk.org
> Cc: David Marchand <david.marchand at redhat.com>; Raslan Darawsheh
> <rasland at oss.nvidia.com>; Xueming Li <xuemingl at oss.nvidia.com>;
> stable at dpdk.org; Harman Kalra <hkalra at marvell.com>; NBU-Contact-
> Thomas Monjalon <thomas at monjalon.net>; Matan Azrad
> <matan at oss.nvidia.com>; Viacheslav Ovsiienko
> <viacheslavo at oss.nvidia.com>
> Subject: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last
> device
>
> MLX5 PMD exposes a socket for external tools to dump port state.
> Socket events are listened using an interrupt source of EXT type.
> The socket was closed and the interrupt callback was unregistered at
> program exit, which is incorrect because DPDK could be already shut down at
> this point. Move actions performed at program exit to the moment the last
> MLX5 port is closed. The socket will be opened again if later a new MLX5
> device is plugged in and probed.
> Also fix comments that were deceisively talking about secondary processes
> instead of external tools.
>
> Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
> Cc: Xueming Li <xuemingl at nvidia.com>
> Cc: stable at dpdk.org
>
> Reported-by: Harman Kalra <hkalra at marvell.com>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk at nvidia.com>
> Acked-by: Thomas Monjalon <thomas at monjalon.net>
> ---
> v2: add Fixes tag
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
More information about the dev
mailing list