[dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag

[Ferruh Yigit]

On 10/22/2021 3:10 PM, Jiang, YuX wrote:
>> -----Original Message-----
>> From: dev <dev-bounces at dpdk.org> On Behalf Of Ferruh Yigit
>> Sent: 2021年10月22日 20:57
>> To: Wang, Haiyue <haiyue.wang at intel.com>; Xing, Beilei
>> <beilei.xing at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Yang, Qiming
>> <qiming.yang at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>; Hyong Youb
>> Kim <hyonkim at cisco.com>; Michal Krawczyk <mk at semihalf.com>; Andrew
>> Rybchenko <andrew.rybchenko at oktetlabs.ru>; Somnath Kotur
>> <somnath.kotur at broadcom.com>
>> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload
>> flag
>>
>> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo
>> frame decisions based on MTU value checks, but some of the checks were
>> wrong by mistake, causing device initialization to fail, fixing them.
>>
>> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> 
> Tested-by: Yu Jiang <YuX.Jiang at intel.com>
> Verify patchset v2 https://patches.dpdk.org/project/dpdk/patch/20211022125716.2706937-2-ferruh.yigit@intel.com/  on dpdk main branch(f4acb429d0 (HEAD, origin/main) hash: promote some functions to stable)
> Tested on i40e(iavf) and it looks good, will test more on others.
> 

Thanks Yu,

I can see it is not fully validated, and most likely it won't be
before -rc1, but it would be good to have this fix for -rc1 to not
block testing.
Since the previous code is clearly wrong, and fixes are similar
between drivers, if one is good I will take risk and merge
the fix for -rc1.