[dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

[Ananyev, Konstantin]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Saturday, October 23, 2021 9:33 AM
> To: Bing Zhao <bingz at nvidia.com>
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; andrew.rybchenko at oktetlabs.ru; dev at dpdk.org; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>
> Subject: Re: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions
> 
> 22/10/2021 23:14, Bing Zhao:
> > When stopping a port, the data path Tx and Rx burst functions should
> > be stopped firstly conventionally. Then the dummy functions are used
> > to replace the callback functions provided by the PMD.
> >
> > When the application stops a port without or before stopping the data
> > path handling. 

If the application really does that, then it is a severe bug in the application,
then needs to be fixed ASAP. 

> The dummy functions may be invoked heavily and a lot
> > of logs in these dummy functions will result in a flood.
> 
> Why does it happen? We should not use a stopped port.
> Is it a problem of core synchronization?
> 
> > Debug level log should be enough instead of the error level.
> 
> 

Dummy function is supposed to be set only when device is not able to do RX/TX properly
(not attached, or attached but not configured, or attached and configured, but not started).
Obviously if app calls rx/tx_burst for such port it is a major issue, that should be flagged immediately.
So I believe having ERR level here makes a perfect sense here.