[dpdk-dev] [PATCH v6 4/9] alarm: remove direct access to interrupt handle

[Dmitry Kozlyuk]

2021-10-24 22:04 (UTC+0200), David Marchand:
> From: Harman Kalra <hkalra at marvell.com>
> 
> Removing direct access to interrupt handle structure fields,
> rather use respective get set APIs for the same.
> Making changes to all the libraries access the interrupt handle fields.
> 
> Implementing alarm cleanup routine, where the memory allocated
> for interrupt instance can be freed.
> 
> Signed-off-by: Harman Kalra <hkalra at marvell.com>
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
> Changes since v5:
> - split from patch4,
> - merged patch6,
> - renamed rte_eal_alarm_fini as rte_eal_alarm_cleanup,
> 
> ---
[...]
> diff --git a/lib/eal/freebsd/eal_alarm.c b/lib/eal/freebsd/eal_alarm.c
> index c38b2e04f8..1a8fcf24c5 100644
> --- a/lib/eal/freebsd/eal_alarm.c
> +++ b/lib/eal/freebsd/eal_alarm.c
> @@ -32,7 +32,7 @@
>  
>  struct alarm_entry {
>  	LIST_ENTRY(alarm_entry) next;
> -	struct rte_intr_handle handle;
> +	struct rte_intr_handle *handle;

This field is never used and can be just removed.

>  	struct timespec time;
>  	rte_eal_alarm_callback cb_fn;
>  	void *cb_arg;
[...]