[dpdk-dev] [dpdk-dev v4 2/9] common/qat: add gen specific device implementation

[Power, Ciara]

Hi Fan,

>-----Original Message-----
>From: dev <dev-bounces at dpdk.org> On Behalf Of Fan Zhang
>Sent: Friday 22 October 2021 18:04
>To: dev at dpdk.org
>Cc: gakhil at marvell.com; Zhang, Roy Fan <roy.fan.zhang at intel.com>; Kusztal,
>ArkadiuszX <arkadiuszx.kusztal at intel.com>; Ji, Kai <kai.ji at intel.com>
>Subject: [dpdk-dev] [dpdk-dev v4 2/9] common/qat: add gen specific device
>implementation
>
>This patch replaces the mixed QAT device configuration implementation by
>separate files with shared or individual implementation for specific QAT
>generation.
>
>Signed-off-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>
>Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com>
>Signed-off-by: Kai Ji <kai.ji at intel.com>
>---
<snip>

>+RTE_INIT(qat_dev_gen_gen1_init)
>+{
>+	qat_dev_hw_spec[QAT_GEN1] = &qat_dev_hw_spec_gen1;
>+	qat_gen_config[QAT_GEN1].dev_gen = QAT_GEN1;
>+	qat_gen_config[QAT_GEN1].comp_num_im_bufs_required =
>+		QAT_NUM_INTERM_BUFS_GEN1;
>+}

This line for setting the comp_num_im_bufs_required field seems to be removed in patch 5, is it needed at all?
If it is needed, maybe it is also required for GEN2/3/4 , which aren't being set below.

<snip>
>+RTE_INIT(qat_dev_gen_gen2_init)
>+{
>+	qat_dev_hw_spec[QAT_GEN2] = &qat_dev_hw_spec_gen2;
>+	qat_gen_config[QAT_GEN2].dev_gen = QAT_GEN2; }
>diff --git a/drivers/common/qat/dev/qat_dev_gen3.c

<snip>

>+RTE_INIT(qat_dev_gen_gen3_init)
>+{
>+	qat_dev_hw_spec[QAT_GEN3] = &qat_dev_hw_spec_gen3;
>+	qat_gen_config[QAT_GEN3].dev_gen = QAT_GEN3; }

<snip>

>+RTE_INIT(qat_dev_gen_4_init)
>+{
>+	qat_dev_hw_spec[QAT_GEN4] = &qat_dev_hw_spec_gen4;
>+	qat_gen_config[QAT_GEN4].dev_gen = QAT_GEN4;
>+	qat_gen_config[QAT_GEN4].pf2vf_dev = &qat_pf2vf_gen4; }

Thanks,
Ciara