[dpdk-dev] [dpdk-dev v4 6/9] compress/qat: add gen specific implementation

[Power, Ciara]

>-----Original Message-----
>From: dev <dev-bounces at dpdk.org> On Behalf Of Fan Zhang
>Sent: Friday 22 October 2021 18:04
>To: dev at dpdk.org
>Cc: gakhil at marvell.com; Zhang, Roy Fan <roy.fan.zhang at intel.com>; Adam
>Dybkowski <adamx.dybkowski at intel.com>; Kusztal, ArkadiuszX
><arkadiuszx.kusztal at intel.com>; Ji, Kai <kai.ji at intel.com>
>Subject: [dpdk-dev] [dpdk-dev v4 6/9] compress/qat: add gen specific
>implementation
>
>This patch replaces the mixed QAT compression support implementation by
>separate files with shared or individual implementation for specific QAT
>generation.
>
>Signed-off-by: Adam Dybkowski <adamx.dybkowski at intel.com>
>Signed-off-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>
>Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com>
>Signed-off-by: Kai Ji <kai.ji at intel.com>
>---
<snip>

>--- /dev/null
>+++ b/drivers/compress/qat/dev/qat_comp_pmd_gens.h
>@@ -0,0 +1,30 @@
>+/* SPDX-License-Identifier: BSD-3-Clause
>+ * Copyright(c) 2021 Intel Corporation
>+ */
>+
>+#ifndef _QAT_COMP_PMD_GEN1_H_
>+#define _QAT_COMP_PMD_GEN1_H_
>+

Maybe this should match the file name.

>+#include <rte_compressdev.h>
>+#include <rte_compressdev_pmd.h>
>+#include <stdint.h>
>+
>+#include "qat_comp_pmd.h"
>+
>+extern const struct rte_compressdev_capabilities
>+qat_gen1_comp_capabilities[];
>+
>+struct qat_comp_capabilities_info
>+qat_comp_cap_get_gen1(struct qat_pci_device *qat_dev);
>+
>+uint16_t qat_comp_get_ram_bank_flags_gen1(void);
>+
>+int qat_comp_set_slice_cfg_word_gen1(struct qat_comp_xform
>*qat_xform,
>+		const struct rte_comp_xform *xform,
>+		enum rte_comp_op_type op_type,
>+		uint32_t *comp_slice_cfg_word);
>+
>+uint64_t qat_comp_get_features_gen1(void);
>+
>+extern struct rte_compressdev_ops qat_comp_ops_gen1;
>+
>+#endif /* _QAT_COMP_PMD_GEN1_H_ */
>--
>2.25.1

Asides from that small comment,
Acked-by: Ciara Power <ciara.power at intel.com>