[dpdk-dev] [PATCH] fib: add rib extension size parameter

[Medvedkin, Vladimir]

Hi Thomas,

On 27/10/2021 10:28, Thomas Monjalon wrote:
> 26/10/2021 22:30, Medvedkin, Vladimir:
>> Hi Thomas,
>>
>> On 25/10/2021 19:23, Thomas Monjalon wrote:
>>> 06/09/2021 17:55, Vladimir Medvedkin:
>>>> This patch adds a new parameter to the fib configuration to specify
>>>> the size of the extension for internal RIB structure.
>>>
>>> It looks to be an announced API change.
>>> What happens if the new field is not initialized in the app?
>>> At least it would deserve a note in the release notes in API changes I think.
>>>
>>
>> This patch was sent for an experimental library, so no update was required.
>> In the patch about the promotion of the FIB API to stable:
>>
>> https://patches.dpdk.org/project/dpdk/patch/1630944075-363524-1-git-send-email-vladimir.medvedkin@intel.com/
>>
>> I put a note about this patch and mentioned that it should be applied
>> before promotion API to stable.
> 
> Indeed, we did not wait.
> 
>> Can we accept it now or we have to wait for next LTS release?
> 
> I think it is OK in this release.
> 

That's great!

> You didn't reply about the release notes. Should we notify an API change?
> Note: even experimental functions should be notified in release notes
> if it requires a code change in the app.
> 

Sure, I'll send v2 with release notes updates.

> 

-- 
Regards,
Vladimir