[dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver

[Vijay Kumar Srivastava]

Hi Stephen,

>-----Original Message-----
>From: Stephen Hemminger <stephen at networkplumber.org>
>Sent: Friday, August 13, 2021 9:06 PM
>To: Vijay Kumar Srivastava <vsrivast at xilinx.com>
>Cc: dev at dpdk.org; maxime.coquelin at redhat.com; chenbo.xia at intel.com;
>andrew.rybchenko at oktetlabs.ru; Vijay Kumar Srivastava <vsrivast at xilinx.com>
>Subject: Re: [dpdk-dev] [PATCH 01/10] vdpa/sfc: introduce Xilinx vDPA driver
>
>On Tue, 6 Jul 2021 22:14:09 +0530
>Vijay Srivastava <vijay.srivastava at xilinx.com> wrote:
>
>> +uint32_t
>> +sfc_vdpa_register_logtype(const struct rte_pci_addr *pci_addr,
>> +			  const char *lt_prefix_str, uint32_t ll_default) {
>> +	size_t lt_prefix_str_size = strlen(lt_prefix_str);
>> +	size_t lt_str_size_max;
>> +	char *lt_str = NULL;
>> +	int ret;
>> +
>> +	if (SIZE_MAX - PCI_PRI_STR_SIZE - 1 > lt_prefix_str_size) {
>> +		++lt_prefix_str_size; /* Reserve space for prefix separator */
>> +		lt_str_size_max = lt_prefix_str_size + PCI_PRI_STR_SIZE + 1;
>> +	} else {
>> +		return RTE_LOGTYPE_PMD;
>> +	}
>> +
>> +	lt_str = rte_zmalloc("logtype_str", lt_str_size_max, 0);
>> +	if (lt_str == NULL)
>> +		return RTE_LOGTYPE_PMD;
>> +
>> +	strncpy(lt_str, lt_prefix_str, lt_prefix_str_size);
>> +	lt_str[lt_prefix_str_size - 1] = '.';
>> +	rte_pci_device_name(pci_addr, lt_str + lt_prefix_str_size,
>> +			    lt_str_size_max - lt_prefix_str_size);
>> +	lt_str[lt_str_size_max - 1] = '\0';
>> +
>> +	ret = rte_log_register_type_and_pick_level(lt_str, ll_default);
>> +	rte_free(lt_str);
>> +
>> +	return (ret < 0) ? RTE_LOGTYPE_PMD : ret; }
>
>This seems like overkill doing per-device log level. Other drivers aren't doing
>this.
We use it for the debugging. This feature is useful for us so it's good to have it.