[dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management

Thomas Monjalon thomas at monjalon.net
Fri Oct 29 16:15:21 CEST 2021


29/10/2021 16:06, Dumitrescu, Cristian:
> From: Thomas Monjalon <thomas at monjalon.net>
> > 28/10/2021 12:17, Liguzinski, WojciechX:
> > > Implement PIE based congestion management based on rfc8033
> > 
> > An explanation is missing about why RED code is removed.
> > I don't know whether it deserves a separate commit,
> > but at least it should be removed consisently in lib and example code
> > in the same patch.
> > 
> > Cristian, please make efforts to help this patchset be properly organized.
> > A blind ack is not enough.
> > 
> 
> The RED code is not removed. It is simply the macro renamed to CMAN (Congestion Management) to include both RED and PIE.

OK, and where this macro is defined?
Why is there such #ifdef?
Even the API is conditionally compiled!




More information about the dev mailing list