[dpdk-dev] [PATCH 08/10] vdpa/sfc: add support for MAC filter config

[Vijay Kumar Srivastava]

Hi Maxime, 

>-----Original Message-----
>From: Maxime Coquelin <maxime.coquelin at redhat.com>
>Sent: Monday, August 30, 2021 7:18 PM
>To: Vijay Kumar Srivastava <vsrivast at xilinx.com>; dev at dpdk.org
>Cc: chenbo.xia at intel.com; andrew.rybchenko at oktetlabs.ru; Vijay Kumar
>Srivastava <vsrivast at xilinx.com>
>Subject: Re: [PATCH 08/10] vdpa/sfc: add support for MAC filter config
>
>
>
>On 7/6/21 6:44 PM, Vijay Srivastava wrote:
>> From: Vijay Kumar Srivastava <vsrivast at xilinx.com>
>>
>> Add support for unicast and broadcast MAC filter configuration.
>
>I wonder whether we should not add an API to the vDPA framework for this
>MAC management, as this is something generic.
>
>What do you think?

I think it's good idea to add an API for MAC configuration in vDPA framework. 

>> Signed-off-by: Vijay Kumar Srivastava <vsrivast at xilinx.com>
>> ---
>>  doc/guides/vdpadevs/sfc.rst        |   4 ++
>>  drivers/vdpa/sfc/meson.build       |   1 +
>>  drivers/vdpa/sfc/sfc_vdpa.c        |  32 +++++++++
>>  drivers/vdpa/sfc/sfc_vdpa.h        |  30 ++++++++
>>  drivers/vdpa/sfc/sfc_vdpa_filter.c | 144
>+++++++++++++++++++++++++++++++++++++
>>  drivers/vdpa/sfc/sfc_vdpa_hw.c     |  10 +++
>>  drivers/vdpa/sfc/sfc_vdpa_ops.c    |  17 +++++
>>  7 files changed, 238 insertions(+)
>>  create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
>>