[dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of PCI ID and address

David Marchand david.marchand at redhat.com
Fri Sep 10 09:18:23 CEST 2021


On Fri, Sep 10, 2021 at 4:38 AM Chenbo Xia <chenbo.xia at intel.com> wrote:
>
> PCI ID and address in structure rte_kni_conf are never used and
> will be removed in kni library. So remove the setting of them
> first in the example.
>
> Signed-off-by: Chenbo Xia <chenbo.xia at intel.com>

(forgot to Cc: Ferruh in previous comment)
Ditto patch 5.

I would tag with a Fixes: on ethtool removal.
Plus, this is the same kind of cleanup wrt kni, you can squash those
two patches together.


Too bad we do not have a deprecation notice.
lib/kni/rte_kni.h:      struct rte_pci_addr addr; /* depreciated */
lib/kni/rte_kni.h:      struct rte_pci_id id; /* depreciated */

Can we plan for this cleanup?


-- 
David Marchand



More information about the dev mailing list