[dpdk-dev] [PATCH v2 1/6] eal: reset lcore function pointer and argument
David Marchand
david.marchand at redhat.com
Fri Sep 10 10:12:10 CEST 2021
On Fri, Sep 10, 2021 at 9:49 AM Bruce Richardson
<bruce.richardson at intel.com> wrote:
>
> On Thu, Sep 09, 2021 at 06:13:07PM -0500, Honnappa Nagarahalli wrote:
> > In the rte_eal_remote_launch function, the lcore function pointer is
> > checked for NULL. However, the pointer is never reset to NULL. Reset the
> > lcore function pointer and argument after the worker has completed
> > executing the lcore function.
> >
> No problems with this patch, but just in general observation. It would be
> good if we had test cases to cover these sorts of problems. If a test were
> added to the autotests for this issue we could observe the issue reproduced
> and easily verify it were fixed by this patch, giving us a high degree of
> confidence in the fix.
+1
--
David Marchand
More information about the dev
mailing list