[dpdk-dev] [PATCH v2] eal: reword logs for CPU and NUMA counts

Thomas Monjalon thomas at monjalon.net
Thu Sep 16 12:39:20 CEST 2021


16/09/2021 12:32, Thomas Monjalon:
> Some logs about cores and nodes were using hypotetic plural (s) form.
> A fixed plural form with value at the end is preferred.
> 
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> ---
> v2: keep plural form as suggested by Bruce
> ---
>  lib/eal/common/eal_common_lcore.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
> index 66d6bad1a7..b38bb46d44 100644
> --- a/lib/eal/common/eal_common_lcore.c
> +++ b/lib/eal/common/eal_common_lcore.c
> @@ -191,9 +191,9 @@ rte_eal_cpu_init(void)
>  	/* Set the count of enabled logical cores of the EAL configuration */
>  	config->lcore_count = count;
>  	RTE_LOG(DEBUG, EAL,
> -		"Support maximum %u logical core(s) by configuration.\n",
> -		RTE_MAX_LCORE);
> -	RTE_LOG(INFO, EAL, "Detected %u lcore(s)\n", config->lcore_count);
> +			"Maximum logical cores by configuration: %u\n",
> +			RTE_MAX_LCORE);
> +	RTE_LOG(INFO, EAL, "Detected CPU lcores: %u\n",config->lcore_count);

space missing above, consider it as fixed ;)

>  
>  	/* sort all socket id's in ascending order */
>  	qsort(lcore_to_socket_id, RTE_DIM(lcore_to_socket_id),
> @@ -208,7 +208,7 @@ rte_eal_cpu_init(void)
>  					socket_id;
>  		prev_socket_id = socket_id;
>  	}
> -	RTE_LOG(INFO, EAL, "Detected %u NUMA nodes\n", config->numa_node_count);
> +	RTE_LOG(INFO, EAL, "Detected NUMA nodes: %u\n", config->numa_node_count);
>  
>  	return 0;
>  }
> 







More information about the dev mailing list