[dpdk-dev] [PATCH v5 0/3] net/i40e: remove i40evf

[Ferruh Yigit]

On 9/17/2021 2:55 AM, Zhang, RobinX wrote:
> Hi, Ferruh
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit at intel.com>
>> Sent: Friday, September 17, 2021 12:28 AM
>> To: Zhang, RobinX <robinx.zhang at intel.com>; dev at dpdk.org
>> Cc: Wang, Haiyue <haiyue.wang at intel.com>; Xing, Beilei
>> <beilei.xing at intel.com>; mdr at ashroe.eu; Wu, Jingjing
>> <jingjing.wu at intel.com>; Burakov, Anatoly <anatoly.burakov at intel.com>;
>> Zhang, Qi Z <qi.z.zhang at intel.com>; Guo, Junfeng <junfeng.guo at intel.com>;
>> Yang, SteveX <stevex.yang at intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v5 0/3] net/i40e: remove i40evf
>>
>> On 9/15/2021 4:09 AM, Robin Zhang wrote:
>>> In DPDK 21.05, iavf already became the default VF for i40e devices.
>>> So remove i40evf due to it's no need to maintain now.
>>>
>>> v5:
>>> - rebase code.
>>>
>>> v4:
>>> - resolve compile warning issue.
>>>
>>> v3:
>>> - remove VF related code in i40e_rxtx.c.
>>>
>>> v2:
>>> - update 21.11 release note, remove some missed documentation.
>>>
>>> Robin Zhang (3):
>>>   net/i40e: remove i40evf
>>>   net/iavf: remove i40evf devargs option
>>>   doc: remove i40evf related documentation
>>>
>>
>> Just to double check, searching 'i40evf' within driver still yields some results
>> [1]. Is this expected? Why they should remain?
> 
> git grep -i i40evf drivers/net/:
> 
> i40e/base/i40e_osdep.h:#define I40EVF_WRITE_FLUSH(a) I40E_READ_REG(a, I40E_VFGEN_RSTAT)
> 	This macro is defined in i40e share code.
> 
> i40e/i40e_ethdev.h:/* I40EVF_DEV_PRIVATE_TO */
> i40e/i40e_ethdev.h:#define I40EVF_DEV_PRIVATE_TO_VF(adapter) \
> i40e/i40e_ethdev.h:             struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(adapter);
> 	This is a helper function "i40e_get_vsi_from_adapter", we still keep the i40e_vf member in i40e_adapter structure for some future possibilities.
> 

What do you mean by "future possibilities"?

> i40e/i40e_vf_representor.c:i40evf_stat_update_48(uint64_t *offset,
> i40e/i40e_vf_representor.c:i40evf_stat_update_32(uint64_t *offset,
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_48(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
> i40e/i40e_vf_representor.c:             i40evf_stat_update_32(
> 	These are ops for VF representor ports of i40e
> 
>>
>>
>> Thanks,
>> ferruh
>>
>>
>> [1]
>> git grep -i i40evf drivers/net/