[dpdk-dev] [PATCH v2] ethdev: change queue release callback
Xueming(Steven) Li
xuemingl at nvidia.com
Fri Sep 17 11:40:49 CEST 2021
On Thu, 2021-09-16 at 17:50 +0200, Thomas Monjalon wrote:
> 16/09/2021 17:43, Xueming(Steven) Li:
> > On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote:
> > > 15/09/2021 15:02, Xueming Li:
> > > > --- a/lib/ethdev/rte_ethdev.c
> > > > +++ b/lib/ethdev/rte_ethdev.c
> > > > - RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, -ENOTSUP);
> > >
> > > Why removing this check?
> > > It is changing the behaviour.
> >
> > Some PMD implemented a dummy callback, so I think maybe it good to make
> > this callback optional to make PMD clean, how do you think?
>
> I agree but it should be a separate patch.
>
Looks good, v3 posted.
>
More information about the dev
mailing list