[dpdk-dev] [PATCH v4 01/11] dma/ioat: add device probe and removal functions

[Conor Walsh]

> On Fri, Sep 17, 2021 at 03:42:17PM +0000, Conor Walsh wrote:
>> Add the basic device probe/remove skeleton code and initial documentation
>> for new IOAT DMA driver. Maintainers update is also included in this
>> patch.
>>
>> Signed-off-by: Conor Walsh <conor.walsh at intel.com>
>> Reviewed-by: Kevin Laatz <kevin.laatz at intel.com>
>> ---
>>   MAINTAINERS                            |  6 +++
>>   doc/guides/dmadevs/index.rst           |  2 +
>>   doc/guides/dmadevs/ioat.rst            | 64 ++++++++++++++++++++++++
>>   doc/guides/rel_notes/release_21_11.rst |  7 +--
>>   drivers/dma/ioat/ioat_dmadev.c         | 69 ++++++++++++++++++++++++++
>>   drivers/dma/ioat/ioat_hw_defs.h        | 35 +++++++++++++
>>   drivers/dma/ioat/ioat_internal.h       | 20 ++++++++
>>   drivers/dma/ioat/meson.build           |  7 +++
>>   drivers/dma/ioat/version.map           |  3 ++
>>   drivers/dma/meson.build                |  1 +
>>   10 files changed, 211 insertions(+), 3 deletions(-)
>>   create mode 100644 doc/guides/dmadevs/ioat.rst
>>   create mode 100644 drivers/dma/ioat/ioat_dmadev.c
>>   create mode 100644 drivers/dma/ioat/ioat_hw_defs.h
>>   create mode 100644 drivers/dma/ioat/ioat_internal.h
>>   create mode 100644 drivers/dma/ioat/meson.build
>>   create mode 100644 drivers/dma/ioat/version.map
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 9cb59b831d..70993d23e8 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1209,6 +1209,12 @@ M: Kevin Laatz <kevin.laatz at intel.com>
>>   F: drivers/dma/idxd/
>>   F: doc/guides/dmadevs/idxd.rst
>>   
>> +Intel IOAT - EXPERIMENTAL
>> +M: Bruce Richardson <bruce.richardson at intel.com>
>> +M: Conor Walsh <conor.walsh at intel.com>
>> +F: drivers/dma/ioat/
>> +F: doc/guides/dmadevs/ioat.rst
>> +
>>   
> Unlike the raw/ioat driver, this dmadev driver does not have a private APIs
> so I'm not sure it needs the EXPERIMENTAL tag on it.

I will update this in v5.

<snip>

>> diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
>> index c0bfd9c1ba..4d2b7bde1b 100644
>> --- a/doc/guides/rel_notes/release_21_11.rst
>> +++ b/doc/guides/rel_notes/release_21_11.rst
>> @@ -92,10 +92,11 @@ New Features
>>     * Device allocation and it's multi-process support.
>>     * Control and data plane functions.
>>   
>> -* **Added IDXD dmadev driver implementation.**
>> +* **Added Intel dmadev driver implementations.**
>>   
>> -  The IDXD dmadev driver provide device drivers for the Intel DSA devices.
>> -  This device driver can be used through the generic dmadev API.
>> +  The IDXD and IOAT dmadev drivers provide device drivers for Intel DSA
>> +  and IOAT devices. These device drivers can be used through the generic
>> +  dmadev API.
>>   
> I'm not sure about merging two driver additions into a single release note
> entry - one for the doc maintainers and tree committers to comment on.
>
> Rather than "IOAT devices" I think the official name of the hardware should
> be used, and you probably should add "respectively" at the end of the first
> sentence to make it clear (once you change the name) which hardware is used
> by which driver.

I will separate them into 2 entries and reword in v5.

Thanks,

Conor.