[dpdk-dev] [PATCH v2 2/5] app/testpmd: fix RSS key length

[Xia, Chenbo]

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin at redhat.com>
> Sent: Wednesday, September 22, 2021 5:58 PM
> To: dev at dpdk.org; Xia, Chenbo <chenbo.xia at intel.com>; amorenoz at redhat.com;
> david.marchand at redhat.com; andrew.rybchenko at oktetlabs.ru; Yigit, Ferruh
> <ferruh.yigit at intel.com>; michaelba at nvidia.com; viacheslavo at nvidia.com; Li,
> Xiaoyun <xiaoyun.li at intel.com>
> Cc: stable at dpdk.org; nelio.laranjeiro at 6wind.com; yvugenfi at redhat.com;
> ybendito at redhat.com; Maxime Coquelin <maxime.coquelin at redhat.com>
> Subject: [PATCH v2 2/5] app/testpmd: fix RSS key length
> 
> port_rss_hash_key_update() initializes rss_conf with the
> RSS key configuration provided  by the user, but it calls

Double space between 'provided' and 'by'

With this fixed:

Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>

> rte_eth_dev_rss_hash_conf_get() before calling
> rte_eth_dev_rss_hash_update(), which overrides the parsed
> RSS config.
> 
> While the RSS key value is set again after, this is not
> the case of the key length. It could cause out of bounds
> access if the key length parsed is smaller than the one
> read from rte_eth_dev_rss_hash_conf_get().
> 
> This patch restores the key length before the
> rte_eth_dev_rss_hash_update() call to ensure the RSS key
> value/length pair is consistent.
> 
> Fixes: 8205e241b2b0 ("app/testpmd: add missing type to RSS hash commands")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>