[dpdk-dev] [PATCH v2 3/5] app/testpmd: fix RSS type display

[Xia, Chenbo]

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin at redhat.com>
> Sent: Wednesday, September 22, 2021 5:58 PM
> To: dev at dpdk.org; Xia, Chenbo <chenbo.xia at intel.com>; amorenoz at redhat.com;
> david.marchand at redhat.com; andrew.rybchenko at oktetlabs.ru; Yigit, Ferruh
> <ferruh.yigit at intel.com>; michaelba at nvidia.com; viacheslavo at nvidia.com; Li,
> Xiaoyun <xiaoyun.li at intel.com>
> Cc: stable at dpdk.org; nelio.laranjeiro at 6wind.com; yvugenfi at redhat.com;
> ybendito at redhat.com; Maxime Coquelin <maxime.coquelin at redhat.com>
> Subject: [PATCH v2 3/5] app/testpmd: fix RSS type display
> 
> This patch fixes the display of the RSS hash types
> configured in the port, which displayed "all" even
> if only a single type was configured
> 
> Fixes: 3c90743dd3b9 ("app/testpmd: support more types for flow RSS")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> ---
>  app/test-pmd/config.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 611965769c..9a4a0c232b 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2833,7 +2833,9 @@ port_rss_hash_conf_show(portid_t port_id, int
> show_rss_key)
>  	}
>  	printf("RSS functions:\n ");
>  	for (i = 0; rss_type_table[i].str; i++) {
> -		if (rss_hf & rss_type_table[i].rss_type)
> +		if (rss_type_table[i].rss_type == 0)
> +			continue;
> +		if ((rss_hf & rss_type_table[i].rss_type) ==
> rss_type_table[i].rss_type)
>  			printf("%s ", rss_type_table[i].str);
>  	}
>  	printf("\n");
> --
> 2.31.1

Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>