[dpdk-dev] [PATCH v4 01/18] net/i40e/base: add new versions of send ASQ command functions

[Ferruh Yigit]

On 9/6/2021 3:02 AM, Robin Zhang wrote:
> ASQ send command functions are returning only i40e status codes
> yet some calling functions also need Admin Queue status
> that is stored in hw->aq.asq_last_status. Since hw object
> is stored on a heap it introduces a possibility for
> a race condition in access to hw if calling function is not
> fast enough to read hw->aq.asq_last_status before next
> send ASQ command is executed.
> 
> Added new versions of send ASQ command functions that return
> Admin Queue status on the stack to avoid race conditions
> in access to hw->aq.asq_last_status.
> Added new _v2 version of i40e_aq_remove_macvlan and i40e_aq_add_macvlan
> that is using new _v2 versions of ASQ send command functions and
> returns the Admin Queue status on the stack.
> 
> Signed-off-by: Sylwester Dziedziuch <sylwesterx.dziedziuch at intel.com>
> Signed-off-by: Robin Zhang <robinx.zhang at intel.com>


I assume ASQ is "Admin Send Queue" (although datasheet refers to it as ATQ), can
you please give the long version of the abbreviations in the commit log in first
usage as:
"ASQ (Admin Send Queue) ... "