[dpdk-dev] [PATCH v4] efd: change data type of parameter

[David Christensen]

On 9/29/21 12:51 AM, De Lara Guarch, Pablo wrote:
> Hi
> 
>> -----Original Message-----
>> From: David Christensen <drc at linux.vnet.ibm.com>
>> Sent: Tuesday, September 28, 2021 4:53 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Wang, Yipeng1
>> <yipeng1.wang at intel.com>; Marohn, Byron <byron.marohn at intel.com>
>> Cc: dev at dpdk.org; Mcnamara, John <john.mcnamara at intel.com>
>> Subject: Re: [PATCH v4] efd: change data type of parameter
>>
>>
>>
>> On 9/28/21 6:58 AM, Pablo de Lara wrote:
>>> rte_efd_create() function was using uint8_t for a socket bitmask, for
>>> one of its parameters.
>>> This limits the maximum of NUMA sockets to be 8.
>>> Changing to to uint64_t increases it to 64, which should be more
>>> future-proof.
>>>
>>> Coverity issue: 366390
>>> Fixes: 56b6ef874f8 ("efd: new Elastic Flow Distributor library")
>>>
>>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
>>> Acked-by: John McNamara <john.mcnamara at intel.com>
>>> ---
>>>
>>> v4: Set socket id in EFD tests
>>>
>>> v3: Fixed commit message
>>>
>>> v2: Fixed EFD tests
>>
>> Results with v4 on a non-consecutive NUMA system:
> 
> ...
> 
>> Test OK
> 
> Great! Thanks a lot for checking. Would you mind adding tested-by to the patch?
> 
> Pablo
> 

Tested-by: David Christensen <drc at linux.vnet.ibm.com>