[dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support

[Thomas Monjalon]

30/09/2021 18:27, Srikanth K:
> Sure, I will follow the Windows support approach.
> 
> Regarding the patches organization, they were arranged logically to the
> best of my knowledge.

It is not.

> The approach followed is to take Linux PMD code and replace the Linux
> dependent part with the
> FreeBSD compatible code. All the removals are of this Linux dependent code.

The removals are in the directory drivers/net/mlx5/freebsd/
That's simple: don't add code that you remove later.

> For the same reason,
> FreeBSD meson support is added in the last patch or otherwise Linux code
> would break compilation
> in FreeBSD.

Simple: add only code which compiles.

> The patches status is still "New" on the DPDK site, please let me know when
> I can submit the next version.

You can submit new versions and mark old ones as superseded.
The full process is described in the contributing guide,
please read it carefully.


> On Wed, Sep 29, 2021 at 9:50 PM Thomas Monjalon <thomas at monjalon.net> wrote:
> 
> > 29/09/2021 17:56, Srikanth K:
> > > Hi Thomas,
> > >
> > > PFA the test report. It covers all the features that were tested across
> > > various platforms.
> > >
> > > The features mentioned in the test report depend on a modified FreeBSD
> > > OFED. There is an ongoing review of these changes by the FreeBSD
> > community.
> > > https://reviews.freebsd.org/p/vag.singh_oneconvergence.com/
> >
> > OK, this dependency is very important to notify in this patchset.
> > For next version, please add it in the cover letter.
> >
> > The supported features (MTU, MAC, VLAN, RSS, fragments, jumbo, stats
> > and trust mode) should be listed in the cover letter as well as
> > in the mlx5 documentation. Please follow what was done for Windows.
> >
> > About the patches organization, please do not fix or remove something
> > which was added in a previous patch. You need to have logical steps
> > done in each patch without going backward.
> > Please start with enabling compilation in first patch,
> > so each step can be tested.
> >
> > Thanks
> >
> >
> >
>