[RFC PATCH v3 4/8] vhost: annotate async accesses

Maxime Coquelin maxime.coquelin at redhat.com
Fri Apr 22 09:20:25 CEST 2022



On 4/11/22 13:00, David Marchand wrote:
> vq->async is initialised and must be accessed under vq->access_lock.
> 
> Top level "_thread_unsafe" functions could be checked at runtime (clang
> provides a lock aware assert()-like check), but they are simply skipped
> because those functions are not called in-tree, and as a result,
> their annotations would not be tested.
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
>   lib/vhost/vhost.c      | 14 +++++++++-----
>   lib/vhost/vhost.h      |  2 +-
>   lib/vhost/vhost_user.c |  2 ++
>   lib/vhost/virtio_net.c | 15 +++++++++++++++
>   4 files changed, 27 insertions(+), 6 deletions(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Thanks,
Maxime



More information about the dev mailing list