[PATCH v3 1/5] vhost: prepare sync for descriptor to mbuf refactoring

Maxime Coquelin maxime.coquelin at redhat.com
Fri Apr 22 17:30:11 CEST 2022


Hi Xuan,

On 4/19/22 05:43, xuan.ding at intel.com wrote:
> From: Xuan Ding <xuan.ding at intel.com>
> 
> This patch extracts the descriptors to buffers filling from
> copy_desc_to_mbuf() into a dedicated function. Besides, enqueue
> and dequeue path are refactored to use the same function
> sync_fill_seg() for preparing batch elements, which simplifies
> the code without performance degradation.
> 
> Signed-off-by: Xuan Ding <xuan.ding at intel.com>
> ---
>   lib/vhost/virtio_net.c | 76 ++++++++++++++++++++----------------------
>   1 file changed, 37 insertions(+), 39 deletions(-)
> 

Nice refactoring, thanks for donig it:

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Thanks,
Maxime



More information about the dev mailing list