[PATCH v1 19/21] net/virtio-user: forward control messages to shadow queue

Maxime Coquelin maxime.coquelin at redhat.com
Tue Dec 6 13:58:25 CET 2022


On 11/30/22 17:54, Stephen Hemminger wrote:
> On Wed, 30 Nov 2022 16:56:37 +0100
> Maxime Coquelin <maxime.coquelin at redhat.com> wrote:
> 
>> +	if (status != 0 || !dev->scvq)
>> +		goto out;
>> +
>> +	status = virtio_send_command(&dev->scvq->cq, (struct virtio_pmd_ctrl *)hdr, dlen, nb_dlen);
>> +out:
> 
> Maybe I am looking at the diff only, and not seeing something but.
> 
> This looks like just an if statement, why the goto here?
> 

The code was a bit more complex initially, but now it has been
simplified, I agree the goto does not make sense anymore.

I will rework it in v2.

Thanks,
Maxime



More information about the dev mailing list