[PATCH v1 1/2] net/axgbe: add multi-process support

Ferruh Yigit ferruh.yigit at amd.com
Fri Dec 23 11:47:02 CET 2022


On 12/23/2022 10:44 AM, Ferruh Yigit wrote:
> On 12/21/2022 2:52 AM, Jesna K E wrote:
>> +/* Takes  ethdev as parameter
>> + *  Used in dev_start by primary process and then
>> + * in dev_init by secondary process when attaching to an existing ethdev.
>> + */
>> +void
>> +axgbe_set_tx_function(struct rte_eth_dev *dev)
>> +{
>> +	struct axgbe_port *pdata = dev->data->dev_private;
>> +	struct axgbe_tx_queue *txq = dev->data->tx_queues[0];
>> +
>> +	if (pdata->multi_segs_tx)
>> +		dev->tx_pkt_burst = &axgbe_xmit_pkts_seg;
>> +#ifdef RTE_ARCH_X86
>> +	if (!txq->vector_disable &&
>> +			rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
>> +		dev->tx_pkt_burst = &axgbe_xmit_pkts_vec;
>> +#else
>> +		dev->tx_pkt_burst = &axgbe_xmit_pkts;

btw, indentation of this line looks wrong

>> +#endif
>> +}
> 
> 'txq' is used only for 'RTE_ARCH_X86', that is why it gives "unused
> variable" warning for it.
> Can you please declare 'txq' within 'RTE_ARCH_X86' macro?



More information about the dev mailing list