[PATCH v3 1/6] ethdev: add L2TPv2 RSS offload type

Ferruh Yigit ferruh.yigit at intel.com
Tue Feb 1 13:19:33 CET 2022


On 1/29/2022 6:24 AM, Jie Wang wrote:
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index 147cc1ced3..29e6091bc8 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -651,6 +651,13 @@ struct rte_eth_rss_conf {
>   #define RTE_ETH_RSS_L4_CHKSUM          RTE_BIT64(35)
>   #define ETH_RSS_L4_CHKSUM RTE_DEPRECATED(ETH_RSS_L4_CHKSUM) RTE_ETH_RSS_L4_CHKSUM
>   
> +/*
> + * Below macro is defined for RSS offload type, it can be used to
> + * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types.
> + */
> +#define RTE_ETH_RSS_L2TPV2            RTE_BIT64(36)
> +#define ETH_RSS_L2TPV2                RTE_ETH_RSS_L2TPV2

Perhaps I wasn't clear, don't have 'ETH_RSS_L2TPV2' at all.

Old macros were missing 'RTE_' prefix, so new ones added with prefix,
and old ones marked as deprecated.
When you are adding a new macro that already starts with 'RTE_' prefix
no need to add old/deprecated style of macro.


Please keep existing acks in next version of the patch.


More information about the dev mailing list