[PATCH] net/enic: adjust memory check and use in proper order

李维国 liwg06 at foxmail.com
Wed Feb 2 13:53:27 CET 2022


This fix only moves the memcpy after null check. 
so the misplaced of memcpy and null check is reordered.
I thought it's too trival a fix to add more explanation.


Sorry if makes any confusion.


-Weiguo


> -----Original Message-----
> From: "Thomas Monjalon" <thomas at monjalon.net>;
> Date: Wed, Feb 2, 2022 07:50 PM
> To: "John Daley (johndale)"<johndale at cisco.com>;"Weiguo Li"<liwg06 at foxmail.com>;
> Cc: "dev"<dev at dpdk.org>;"Ferruh Yigit"<ferruh.yigit at intel.com>;
> Subject: Re: [PATCH] net/enic: adjust memory check and use in proper order
>

> > > Subject: [PATCH] net/enic: adjust memory check and use in proper order
> > >
> > > Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
> > >
> > > Signed-off-by: Weiguo Li <liwg06 at foxmail.com>
> > >
> > > Reviewed-by: John Daley <johndale at cisco.com>
> > >
> > > Applied to dpdk-next-net/main, thanks.

 > Please could we have a little of explanation in the commit log?
 > The title says "adjust [...] and use in proper order"
 > but I see only a move of the check.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20220202/66e873a6/attachment-0001.htm>


More information about the dev mailing list