[EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

[Stephen Hemminger]

On Mon, 7 Feb 2022 18:28:03 +0000
Akhil Goyal <gakhil at marvell.com> wrote:

> > On Mon, 7 Feb 2022 17:28:26 +0000
> > Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> >   
> > > On 2/7/2022 5:23 PM, Stephen Hemminger wrote:  
> > > > On Sat, 5 Feb 2022 03:43:33 +0530
> > > > Akhil Goyal <gakhil at marvell.com> wrote:
> > > >  
> > > >> +/**
> > > >> + * @internal
> > > >> + * Register mbuf dynamic field and flag for IP reassembly incomplete  
> > case.  
> > > >> + */
> > > >> +__rte_internal
> > > >> +int
> > > >> +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag);  
> > > >
> > > > Maybe use RTE_INIT() constructor for this?  
> > >
> > > Dynfiled should be registered only when users asks for the feature.  
> > 
> > right but making the user ask can lead to errors, can it be done implicitly
> > on first use.  
> 
> Registering dynfield is responsibility of PMD when the application asks for the feature.
> So how can it lead to errors.

Sorry, forgot this is a PMD internal thing.