[PATCH 6/7] vhost: remove non-C++ compatible includes

[Bruce Richardson]

On Wed, Feb 09, 2022 at 09:10:36AM +0000, Wang, Xiao W wrote:
> Hi Bruce,
> 
> > -----Original Message----- From: Richardson, Bruce
> > <bruce.richardson at intel.com> Sent: Saturday, February 5, 2022 2:19 AM
> > To: dev at dpdk.org Cc: Maxime Coquelin <maxime.coquelin at redhat.com>; Xia,
> > Chenbo <chenbo.xia at intel.com>; Wang, Xiao W <xiao.w.wang at intel.com>;
> > Matan Azrad <matan at nvidia.com>; Viacheslav Ovsiienko
> > <viacheslavo at nvidia.com> Subject: Re: [PATCH 6/7] vhost: remove non-C++
> > compatible includes
> >
> > On Fri, Feb 04, 2022 at 05:42:08PM +0000, Bruce Richardson wrote:
> > > Some of the linux header includes are explicitly noted as being
> > > incompatible with C++. However, these headers can included by C files
> > > directly, or by internal headers, to avoid polluting the public DPDK
> > > headers with non-C++ safe includes.
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com> ---
> >
> > CI is reporting build issues with this patch on examples, something I'm
> > not surprised to see. I will wait for maintainer feedback on best
> > approach before respinning patchset.
> >
> > /Bruce
> 
> Could we move these c++ incompatible linux headers into #ifndef
> __cplusplus ...  #endif.  Then we just need to change rte_vhost.h file,
> and don't break build for the drivers and samples.
>
I was thinking that something similar would work, but it's not the most
elegant, and strikes me as a bit of a hack. If it's generally acceptable,
though, I'm happy enough to respin the patch with that fix.

/Bruce