[PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03

[Thomas Monjalon]

12/02/2022 15:01, Yanling Song:
> On Fri, 21 Jan 2022 10:22:10 +0000
> Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> 
> > On 1/21/2022 9:27 AM, Yanling Song wrote:
> > > On Wed, 19 Jan 2022 16:56:52 +0000
> > > Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> > >   
> > >> On 12/30/2021 6:08 AM, Yanling Song wrote:  
> > >>> The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial
> > >>> NIC cards into DPDK 22.03. Ramaxel Memory Technology is a company
> > >>> which supply a lot of electric products: storage, communication,
> > >>> PCB... SPNxxx is a serial PCIE interface NIC cards:
> > >>> SPN110: 2 PORTs *25G
> > >>> SPN120: 4 PORTs *25G
> > >>> SPN130: 2 PORTs *100G
> > >>>      
> > >>
> > >> Hi Yanling,
> > >>
> > >> As far as I can see hnic (from Huawei) and this spnic drivers are
> > >> alike, what is the relation between these two?
> > > 
> > > It is hard to create a brand new driver from scratch, so we
> > > referenced to hinic driver when developing spnic.
> > 
> > That is OK, but based on the familiarity of the code you may consider
> > keeping the original code Copyright, I didn't investigate in
> > that level but cc'ed hinic maintainers for info.
> > Also cc'ed Hemant for guidance.

What is the percentage of familiarity in the code?

> Sorry for late reponse since it was Spring Festival and I was in
> vacation, just back to work.
> 
> Hemant gave the guidance already, but we do not want to keep another
> company's copyright in our code.
> How should we modify code so that the
> code meet DPDK's requirment and can be accepted with our copyright
> only? 

If you don't want to keep a copyright, don't copy the code.

> > But my question was more related to the HW, is there any relation
> > between the hinic HW and spnic HW? Like one is derived from other
> > etc...
> 
> I'm not clear what's the relation between hinic/spnic hw since we do
> not know what's the hinic hw.

Do you mean you are copying a driver and its design choices
without understanding what it does?