[PATCH v4] app/eventdev: add crypto producer mode

[Gujjar, Abhinandan S]

Hi Shijith,

> -----Original Message-----
> From: Shijith Thotton <sthotton at marvell.com>
> Sent: Tuesday, February 8, 2022 10:03 PM
> To: dev at dpdk.org; jerinj at marvell.com; Gujjar, Abhinandan S
> <abhinandan.gujjar at intel.com>
> Cc: Shijith Thotton <sthotton at marvell.com>
> Subject: [PATCH v4] app/eventdev: add crypto producer mode
> 
> In crypto producer mode, producer core enqueues cryptodev with software
> generated crypto ops and worker core dequeues crypto completion events
> from the eventdev. Event crypto metadata used for above processing is pre-
> populated in each crypto session.
> 
> Parameter --prod_type_cryptodev can be used to enable crypto producer
> mode. Parameter --crypto_adptr_mode can be set to select the crypto
> adapter mode, 0 for OP_NEW and 1 for OP_FORWARD.
> 
> This mode can be used to measure the performance of crypto adapter.
> 
> Example:
>   ./dpdk-test-eventdev -l 0-2 -w <EVENTDEV> -w <CRYPTODEV> -- \
>   --prod_type_cryptodev --crypto_adptr_mode 1 --test=perf_atq \
>   --stlist=a --wlcores 1 --plcores 2
> 
> Signed-off-by: Shijith Thotton <sthotton at marvell.com>
> ---

<SNIP>
Reposting your comments from previous patch:
I tried adding support for software adapter implementation, but is getting a crash in sw_event PMD after some packets. I have posted the respective changes
here: https://patchwork.dpdk.org/project/dpdk/patch/0677cbafa5145f1b9f64dd007594e033f2d9ab8a.1644337310.git.sthotton@marvell.com/
Please take it forward.

Command used to test is:
dpdk-test-eventdev -l 0-8 -s 0xf0 --vdev=event_sw0  --vdev="crypto_null" --    \
      --prod_type_cryptodev --crypto_adptr_mode 1 --test=perf_queue --stlist=a \
      --wlcores 1 --plcores 2

I tried to get the above command working with your patches. As you mentioned,
I see a crash! If I change the --test to any other queue, I see a totally irrelevant
error message:
error: pipeline_opt_check() Invalid producer type 'Event crypto adapter' valid producer 'Ethdev Rx Adapter'
error: main() invalid command line argument

I think, running a test with minimal configuration like sw_event, sw adapter & null cryptodev without
any vendor specific HW is very important to acknowledge a patch. Later, this code will be a reference
for adding performance test for any specific HW.
Right now, I can't think of any other options to see a working test.
If you know any other ways to test this code, please let me.

Thanks
Abhinandan