[PATCH] net/iavf: fix segmentation offload buffer size

Nicolau, Radu radu.nicolau at intel.com
Tue Feb 15 13:30:10 CET 2022


On 2/15/2022 11:19 AM, Ferruh Yigit wrote:
> On 2/15/2022 10:47 AM, Nicolau, Radu wrote:
>>
>> On 2/15/2022 10:06 AM, Ferruh Yigit wrote:
>>> On 2/10/2022 1:09 PM, Radu Nicolau wrote:
>>>> This reverts commit ff8b8bcd2ebe, which resulted in incorrect 
>>>> buffer size
>>>> being computed for TSO packets.
>>>>
>>>> Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition")
>>>>
>>>
>>> Commit 'ff8b8bcd2ebe' was already fixing segmentation offload,
>>> are we having the initial issue back when this patch reverted?
>>> Is there a fix for that initial issue?
>> The initial issue was around a very specific usecase - IPsec 
>> transport mode TSO and it is very likely back with this revert. But 
>> it's a much less severe impact than general traffic TSO.
>
> Got it, so this revert brings back an issue, should
> we document this in the commit log of this patch?
> Plus should we create a Bugzilla etc to record the
> introduced issue?

I plan to follow up with a fix shortly.

As for the commit message, since this was not merged to the LTS and 
main, do we really need it?




More information about the dev mailing list