[PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd

[Zhang, Yuying]

Hi Wenxuan,

> -----Original Message-----
> From: Wu, WenxuanX <wenxuanx.wu at intel.com>
> Sent: Thursday, February 17, 2022 6:14 PM
> To: Yang, Qiming <qiming.yang at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>; Li, Xiaoyun <xiaoyun.li at intel.com>; Singh, Aman Deep
> <aman.deep.singh at intel.com>; Zhang, Yuying <yuying.zhang at intel.com>
> Cc: dev at dpdk.org
> Subject: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd
> 
> From: wenxuan wu <wenxuanx.wu at intel.com>
> 
> There is a heap-free-after-use bug when quit testpmd with pf and vfs, stop and
> close ports in reverse order is a more reasonable approach.

Please explain the issue and your fix in detail. Since your patch is a fix, you need a fix line here.

> Cc: stable at dpdk.org
> 
> Signed-off-by: wenxuan wu <wenxuanx.wu at intel.com>
> ---
>  lib/ethdev/rte_ethdev.h | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index
> 2660e4f374..e080840b06 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -2185,9 +2185,13 @@ struct rte_eth_dev_owner {
>   * @return
>   *   Next valid port ID owned by owner_id, RTE_MAX_ETHPORTS if there is none.
>   */
> -uint64_t rte_eth_find_next_owned_by(uint16_t port_id,
> +uint64_t
> +rte_eth_find_next_owned_by(uint16_t port_id,
>  		const uint64_t owner_id);
> 
> +uint64_t
> +rte_eth_find_prev_owned_by(uint16_t port_id, const uint64_t owner_id);
> +

Please keep consistency of code style of similar declaration.

>  /**
>   * Macro to iterate over all enabled ethdev ports owned by a specific owner.
>   */
> @@ -2212,6 +2216,14 @@ uint16_t rte_eth_find_next(uint16_t port_id);
> #define RTE_ETH_FOREACH_DEV(p) \
>  	RTE_ETH_FOREACH_DEV_OWNED_BY(p, RTE_ETH_DEV_NO_OWNER)
> 
> +/**
> + * Macro to iterate over all enabled and ownerless ethdev ports in reverse
> order, for quit purpose.
> + */
> +#define RTE_ETH_FOREACH_DEV_REVERSE(p) \
> +	for (p = (rte_eth_dev_count_total() - 1 >= 0) ?
> (rte_eth_dev_count_total() - 1) : 0; \
> +	     p < rte_eth_dev_count_total(); \
> +	     p--)

Use rte_eth_dev_count_total() function can only get the number of valid port instead of
port id separately. You should can refer to the logic of RTE_ETH_FOREACH_DEV(p).

> +
>  /**
>   * Iterates over ethdev ports of a specified device.
>   *
> --
> 2.25.1