[dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process

[Dong, Yao]

are those patch available/merged in dpdk 21.11?

Dong yao (from my iPhone)

> 在 2022年2月22日，下午5:26，Kevin Traynor <ktraynor at redhat.com> 写道：
> 
> On 22/02/2022 04:30, Zhang, Qi Z wrote:
>> Hi Srinivas:
>> This is the fix for PF driver only, for VF we have a separated fix and it is not be captured in 20.11.3, but I saw the patches are already merged in stable tree.
>> You can try with latest 20.11.4-rc1,   or wait for 20.11.4 LTS.
> 
> 20.11.4 is already released. Xueming sent details here
> http://inbox.dpdk.org/announce/20220124084950.482883-1-xuemingl@nvidia.com/T/#u
> 
> You can check the release notes (or git) for specific fixes
> https://git.dpdk.org/dpdk-stable/tree/doc/guides/rel_notes/release_20_11.rst?h=20.11
> 
>> Regards
>> Qi
>> From: Navin Srinivas <g.navinsrinivas at gmail.com>
>> Sent: Tuesday, February 22, 2022 11:56 AM
>> To: Zhang, Qi Z <qi.z.zhang at intel.com>
>> Cc: Wang, Yixue <yixue.wang at intel.com>; Yang, Qiming <qiming.yang at intel.com>; Zhang, Liheng <liheng.zhang at intel.com>; Dong, Yao <yao.dong at intel.com>; dev at dpdk.org; stable at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process
>> Hi,
>> Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1, but did not see PF crash on 20.11.3,
>> I'm seeing a crash on the secondary process when it receives packet on the VF, but PF doesn't crash now on 20.11.3
>> So I suspect this is the patch which is fixing the issue on ICE secondary process crash on PF.
>> Thanks & Regards,
>> Navin Srinivas
>>> On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z <qi.z.zhang at intel.com<mailto:qi.z.zhang at intel.com>> wrote:
>>> -----Original Message-----
>>> From: Wang, Yixue <yixue.wang at intel.com<mailto:yixue.wang at intel.com>>
>>> Sent: Thursday, June 3, 2021 6:04 PM
>>> To: Zhang, Qi Z <qi.z.zhang at intel.com<mailto:qi.z.zhang at intel.com>>; Yang, Qiming
>>> <qiming.yang at intel.com<mailto:qiming.yang at intel.com>>
>>> Cc: Zhang, Liheng <liheng.zhang at intel.com<mailto:liheng.zhang at intel.com>>; Dong, Yao
>>> <yao.dong at intel.com<mailto:yao.dong at intel.com>>; dev at dpdk.org<mailto:dev at dpdk.org>; stable at dpdk.org<mailto:stable at dpdk.org>
>>> Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary
>>> process
>>> 
>>> Hi, Qi
>>> 
>>> I've tested this patch and it works.
>>> 
>>> Best Regards,
>>> Yixue.
>>> 
>>>> -----Original Message-----
>>>> From: Zhang, Qi Z <qi.z.zhang at intel.com<mailto:qi.z.zhang at intel.com>>
>>>> Sent: Monday, May 24, 2021 17:08
>>>> To: Yang, Qiming <qiming.yang at intel.com<mailto:qiming.yang at intel.com>>
>>>> Cc: Zhang, Liheng <liheng.zhang at intel.com<mailto:liheng.zhang at intel.com>>; Wang, Yixue
>>>> <yixue.wang at intel.com<mailto:yixue.wang at intel.com>>; Dong, Yao <yao.dong at intel.com<mailto:yao.dong at intel.com>>; dev at dpdk.org<mailto:dev at dpdk.org>;
>>>> Zhang, Qi Z <qi.z.zhang at intel.com<mailto:qi.z.zhang at intel.com>>; stable at dpdk.org<mailto:stable at dpdk.org>
>>>> Subject: [PATCH] net/ice: fix wrong data path selection in secondary
>>>> process
>>>> 
>>>> The flag use_avx2 and use_avx512 are defined as local variables, they
>>>> will not be aware by the secondary process, then wrong data path is
>>>> selected. Fix the issue by moving them into struct ice_adapter.
>>>> 
>>>> Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector")
>>>> Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx")
>>>> Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")
>>>> Cc: stable at dpdk.org<mailto:stable at dpdk.org>
>>>> 
>>>> Reported-by: Yixue Wang <yixue.wang at intel.com<mailto:yixue.wang at intel.com>>
>>>> Signed-off-by: Qi Zhang <qi.z.zhang at intel.com<mailto:qi.z.zhang at intel.com>>
>> Tested-by: Yixue Wang <yixue.wang at intel.com<mailto:yixue.wang at intel.com>>
>> Applied to dpdk-next-net-intel.
>> Thanks
>> Qi
>