[PATCH v1] power: add wakeup log
Li, Miao
miao.li at intel.com
Thu Feb 24 03:45:09 CET 2022
Hi,
> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Wednesday, February 23, 2022 12:07 AM
> To: Li, Miao <miao.li at intel.com>
> Cc: dev at dpdk.org; Hunt, David <david.hunt at intel.com>; Wang, Yinan
> <yinan.wang at intel.com>
> Subject: Re: [PATCH v1] power: add wakeup log
>
> On Tue, 22 Feb 2022 13:52:27 +0000
> Miao Li <miao.li at intel.com> wrote:
>
> > + "lcore %u is waked up from value change\n",
>
> That is awkward phrasing in English and should be DEBUG not INFO level
> because it may happen often.
I will fix it in the next version.
>
> Maybe:
> "lcore %u awoke because value changed\n"
> or something better.
I will change the log content in next version.
>
> PS: sometimes it is good idea to using grammar tools when wording commit
> or messages.
Thanks,
Miao
More information about the dev
mailing list