[PATCH 1/1] fix spelling in code

[Thomas Monjalon]

12/01/2022 08:28, Josh Soref:
> Some additional comment fixes...

They are not only comments, some are functions or struct fields.

> The tool comes from https://github.com/jsoref

It requires some reviews. I started to review below.

> -cpt_lfs_alloc(struct dev *dev, uint8_t eng_grpmsk, uint8_t blkaddr,
> +cpt_lfs_alloc(struct dev *dev, uint8_t eng_grpmask, uint8_t blkaddr,

grpmsk is shorter and understandable.
Adding some letters is not a fix in this case.

> -cnstr_shdsc_authenc(uint32_t *descbuf, bool ps, bool swap,
> +cnstr_shdsc_authentic(uint32_t *descbuf, bool ps, bool swap,

That's a wrong change: authenc means authentication + encryption.

> -#define COMPRESSDEV_NAME_ZIP_PMD	compress_octeonx
> +#define COMPRESSDEV_NAME_ZIP_PMD	compress_octeontx

Good catch! I wonder how your tool finds it.

> -		comp_dev->interm_buff_mz =
> +		comp_dev->interim_buff_mz =

Not sure about this one.

> -	UPDATE_STAT64(rx_stat_grxpf, rx_stat_xoffstateentered);
> +	UPDATE_STAT64(rx_stat_grxpf, rx_stat_xoffsetateentered);

Looks wrong.

> - * inner_ofst: If zero, this is an outer header. If non-zero, this is
> + * inner_offset: If zero, this is an outer header. If non-zero, this is

I would not change this to respect how the author shortened it.

> @@ -106,7 +106,7 @@ typedef struct VhostUserCryptoSessionParam {
>  	uint8_t dir;
>  	uint8_t hash_mode;
>  	uint8_t chaining_dir;
> -	uint8_t *ciphe_key;
> +	uint8_t *cipher_key;
>  	uint8_t *auth_key;
>  	uint8_t cipher_key_buf[VHOST_USER_CRYPTO_MAX_CIPHER_KEY_LENGTH];
>  	uint8_t auth_key_buf[VHOST_USER_CRYPTO_MAX_HMAC_KEY_LENGTH];

It looks to be unused. Is it an API change?