[PATCH v4 01/53] devtools: script to remove unused headers includes
Bruce Richardson
bruce.richardson at intel.com
Fri Jan 14 18:36:51 CET 2022
On Fri, Jan 14, 2022 at 09:02:40AM -0800, Stephen Hemminger wrote:
> On Fri, 14 Jan 2022 16:23:17 +0000
> Sean Morrissey <sean.morrissey at intel.com> wrote:
>
> > This script can be used for removing headers flagged for removal by the
> > include-what-you-use (IWYU) tool. The script has the ability to remove
> > headers from specified sub-directories or dpdk as a whole and tests the
> > build after each removal by calling meson compile.
> >
> > example usages:
> >
> > Remove headers flagged by iwyu_tool output file
> > $ ./devtools/process_iwyu.py iwyu.out -b build
> >
> > Remove headers flagged by iwyu_tool output file from sub-directory
> > $ ./devtools/process_iwyu.py iwyu.out -b build -d lib/kvargs
> >
> > Remove headers directly piped from the iwyu_tool
> > $ iwyu_tool -p build | ./devtools/process_iwyu.py - -b build
> >
> > Signed-off-by: Sean Morrissey <sean.morrissey at intel.com>
> > Signed-off-by: Conor Fogarty <conor.fogarty at intel.com>
> >
> > Reviewed-by: Bruce Richardson <bruce.richardson at intel.com>
>
> Could this be a shell script instead of python?
> That would prevent having to pull in more python library dependencies.
Can you clarify what python library dependencies are you concerned about?
AFAIK everything in this script is just from the standard built-in python
library - Sean, perhaps you can confirm? Converting to shell would lead to
something far less readable, IMHO, and it would be less portable to windows
too in future.
/Bruce
More information about the dev
mailing list