[PATCH v6 05/26] net/spnic: add mgmt module
Yanling Song
songyl at ramaxel.com
Fri Jan 21 10:33:24 CET 2022
On Wed, 19 Jan 2022 17:22:51 +0000
Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> On 12/30/2021 6:08 AM, Yanling Song wrote:
> > Mgmt module manage the message gerenated from the hardware.
> > This patch implements mgmt module initialization, related event
> > processing and message command definition.
> >
> > Signed-off-by: Yanling Song <songyl at ramaxel.com>
>
> <...>
>
> > +static void spnic_get_port_link_info(u8 link_state, struct
> > rte_eth_link *link) +{
> > + if (!link_state) {
> > + link->link_status = ETH_LINK_DOWN;
> > + link->link_speed = ETH_SPEED_NUM_NONE;
> > + link->link_duplex = ETH_LINK_HALF_DUPLEX;
> > + link->link_autoneg = ETH_LINK_FIXED;
> > + }
>
> The driver is using deprecated macros. If you can rebase on top of
> latest next-net, you will get the warnings.
>
> Since it is hard to continue with bunch of build errors, I will wait
> for next version and can continue the reviews with it.
Thanks for pointing it out. Will use new macros to replace the old ones
in the next version.
More information about the dev
mailing list