[PATCH 54/82] net/ixgbe: remove unnecessary NULL checks

[Wang, Haiyue]

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Monday, January 24, 2022 08:05
> To: dev at dpdk.org
> Cc: Stephen Hemminger <stephen at networkplumber.org>; Wang, Haiyue <haiyue.wang at intel.com>
> Subject: [PATCH 54/82] net/ixgbe: remove unnecessary NULL checks
> 
> Remove redundant NULL pointer checks before free functions
> found by nullfree.cocci
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 10 +++-------
>  drivers/net/ixgbe/ixgbe_rxtx.c   |  3 +--
>  2 files changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index c8f0460440c0..840509ddd460 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -1322,10 +1322,8 @@ static int ixgbe_fdir_filter_uninit(struct rte_eth_dev *eth_dev)
>  		IXGBE_DEV_PRIVATE_TO_FDIR_INFO(eth_dev->data->dev_private);
>  	struct ixgbe_fdir_filter *fdir_filter;
> 
> -		if (fdir_info->hash_map)
>  		rte_free(fdir_info->hash_map);

This " rte_free(fdir_info->hash_map);" needs to be adjusted by removing one tab. ;-)

> -	if (fdir_info->hash_handle)
> -		rte_hash_free(fdir_info->hash_handle);
> +	rte_hash_free(fdir_info->hash_handle);
> 


> --
> 2.30.2