[PATCH v2 75/83] vdpa/ifc: remove unnecessary NULL checks

[Xia, Chenbo]

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Tuesday, January 25, 2022 1:47 AM
> To: dev at dpdk.org
> Cc: Stephen Hemminger <stephen at networkplumber.org>; Wang, Xiao W
> <xiao.w.wang at intel.com>
> Subject: [PATCH v2 75/83] vdpa/ifc: remove unnecessary NULL checks
> 
> Remove redundant NULL pointer checks before free functions
> found by nullfree.cocci
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  drivers/vdpa/ifc/ifcvf_vdpa.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 3853c4cf7e85..9f05595b6b34 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -226,8 +226,7 @@ ifcvf_dma_map(struct ifcvf_internal *internal, bool do_map)
>  	}
> 
>  exit:
> -	if (mem)
> -		free(mem);
> +	free(mem);
>  	return ret;
>  }
> 
> @@ -253,8 +252,7 @@ hva_to_gpa(int vid, uint64_t hva)
>  	}
> 
>  exit:
> -	if (mem)
> -		free(mem);
> +	free(mem);
>  	return gpa;
>  }
> 
> @@ -661,8 +659,7 @@ m_ifcvf_start(struct ifcvf_internal *internal)
> 
>  error:
>  	for (i = 0; i < nr_vring; i++)
> -		if (internal->m_vring[i].desc)
> -			rte_free(internal->m_vring[i].desc);
> +		rte_free(internal->m_vring[i].desc);
> 
>  	return -1;
>  }
> --
> 2.30.2

Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>