[EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options

[Sunil Kumar Kori]

>-----Original Message-----
>From: Ferruh Yigit <ferruh.yigit at intel.com>
>Sent: Tuesday, January 25, 2022 11:07 PM
>To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; dev at dpdk.org; Xiaoyun
>Li <xiaoyun.li at intel.com>; Aman Singh <aman.deep.singh at intel.com>; Yuying
>Zhang <yuying.zhang at intel.com>
>Cc: thomas at monjalon.net; ajit.khaparde at broadcom.com;
>aboyer at pensando.io; andrew.rybchenko at oktetlabs.ru;
>beilei.xing at intel.com; bruce.richardson at intel.com; chas3 at att.com;
>chenbo.xia at intel.com; ciara.loftus at intel.com; Devendra Singh Rawat
><dsinghrawat at marvell.com>; ed.czeck at atomicrules.com;
>evgenys at amazon.com; grive at u256.net; g.singh at nxp.com;
>zhouguoyang at huawei.com; haiyue.wang at intel.com; Harman Kalra
><hkalra at marvell.com>; heinrich.kuhn at corigine.com;
>hemant.agrawal at nxp.com; hyonkim at cisco.com; igorch at amazon.com; Igor
>Russkikh <irusskikh at marvell.com>; jgrajcia at cisco.com;
>jasvinder.singh at intel.com; jianwang at trustnetic.com;
>jiawenwu at trustnetic.com; jingjing.wu at intel.com; johndale at cisco.com;
>john.miller at atomicrules.com; linville at tuxdriver.com; keith.wiles at intel.com;
>Kiran Kumar Kokkilagadda <kirankumark at marvell.com>;
>oulijun at huawei.com; Liron Himi <lironh at marvell.com>;
>longli at microsoft.com; mw at semihalf.com; spinler at cesnet.cz;
>matan at nvidia.com; matt.peters at windriver.com;
>maxime.coquelin at redhat.com; mk at semihalf.com; humin29 at huawei.com;
>Pradeep Kumar Nalla <pnalla at marvell.com>; Nithin Kumar Dabilpuram
><ndabilpuram at marvell.com>; qiming.yang at intel.com; qi.z.zhang at intel.com;
>Radha Chintakuntla <radhac at marvell.com>; rahul.lakkireddy at chelsio.com;
>Rasesh Mody <rmody at marvell.com>; rosen.xu at intel.com;
>sachin.saxena at oss.nxp.com; Satha Koteswara Rao Kottidi
><skoteshwar at marvell.com>; Shahed Shaikh <shshaikh at marvell.com>;
>shaibran at amazon.com; shepard.siegel at atomicrules.com;
>asomalap at amd.com; somnath.kotur at broadcom.com;
>sthemmin at microsoft.com; steven.webster at windriver.com; Sunil Kumar Kori
><skori at marvell.com>; mtetsuyah at gmail.com; Veerasenareddy Burru
><vburru at marvell.com>; viacheslavo at nvidia.com; xiao.w.wang at intel.com;
>cloud.wangxiaoyun at huawei.com; yisen.zhuang at huawei.com;
>yongwang at vmware.com; xuanziyang2 at huawei.com
>Subject: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based
>pfc CLI options
>
>External Email
>
>----------------------------------------------------------------------
>On 1/13/2022 10:27 AM, jerinj at marvell.com wrote:
>> From: Sunil Kumar Kori <skori at marvell.com>
>>
>> Patch adds command line options to configure queue based priority flow
>> control.
>>
>> - Syntax command is given as below:
>>
>> set pfc_queue_ctrl <port_id> rx <on|off> <tx_qid> <tx_tc> \
>> 	tx <on|off> <rx_qid> <rx_tc> <pause_time>
>>
>
>Isn't the order of the paramters odd, it is mixing Rx/Tx config, what about
>ordering Rx and Tx paramters?
>
It's been kept like this to portray config for rx_pause and tx_pause separately i.e. mode and corresponding config.

>> - Example command to configure queue based priority flow control
>>    on rx and tx side for port 0, Rx queue 0, Tx queue 0 with pause
>>    time 2047
>>
>> testpmd> set pfc_queue_ctrl 0 rx on 0 0 tx on 0 0 2047
>>
>> Signed-off-by: Sunil Kumar Kori <skori at marvell.com>
>
><...>