[PATCH] net/mlx5: fix verbs fd leak in the secondary process

longli at linuxonhyperv.com longli at linuxonhyperv.com
Wed Jul 6 19:22:25 CEST 2022


From: Long Li <longli at microsoft.com>

FDs passed from rte_mp_msg are duplicated to the secondary process and
need to be closed.

Fixes: 9a8ab29b84 ("net/mlx5: replace IPC socket with EAL API")
Signed-off-by: Long Li <longli at microsoft.com>
---
 drivers/net/mlx5/mlx5_txq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index 4e0bf7af9c..df55a4cd25 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -636,6 +636,7 @@ mlx5_tx_uar_init_secondary(struct rte_eth_dev *dev, int fd)
 		if (ret)
 			goto error;
 	}
+	close(fd);
 	return 0;
 error:
 	/* Rollback. */
@@ -646,6 +647,7 @@ mlx5_tx_uar_init_secondary(struct rte_eth_dev *dev, int fd)
 		txq_ctrl = container_of(txq, struct mlx5_txq_ctrl, txq);
 		txq_uar_uninit_secondary(txq_ctrl);
 	} while (i--);
+	close(fd);
 	return -rte_errno;
 }
 
-- 
2.17.1



More information about the dev mailing list