[RFC PATCH 04/29] net/qdma: add logging support

Aman Kumar aman.kumar at vvdntech.in
Thu Jul 7 04:32:58 CEST 2022


On 06/07/22 8:57 pm, Stephen Hemminger wrote:
> On Wed,  6 Jul 2022 13:21:54 +0530
> Aman Kumar <aman.kumar at vvdntech.in> wrote:
>
>> +extern int qdma_logtype_pmd;
>> +#define PMD_DRV_LOG(level, fmt, args...) \
>> +	rte_log(RTE_LOG_ ## level, qdma_logtype_pmd, "%s(): " \
>> +		fmt "\n", __func__, ## args)
> Did  you test this. Looks like your log messages are going
> to end up double spaced. Because many of the later calls put a
> newline on the message. Example:
>
> +	PMD_DRV_LOG(INFO, "QDMA devargs desc_prefetch is: %s\n", value);

Additional lines did not bother us during feature testing. I'll fix this 
in v2.
Thanks for pointing this.



More information about the dev mailing list