[Patch v3 10/17] net/mana: implement memory registration

Long Li longli at microsoft.com
Fri Jul 8 00:12:16 CEST 2022


> Subject: Re: [Patch v3 10/17] net/mana: implement memory registration
> 
> On Thu,  7 Jul 2022 13:30:15 -0700
> longli at linuxonhyperv.com wrote:
> 
> > +int mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv
> *priv,
> > +		    struct rte_mempool *pool)
> > +{
> > +	struct ibv_mr *ibv_mr;
> > +	struct mana_range ranges[pool->nb_mem_chunks];
> > +	uint32_t i;
> > +	struct mana_mr_cache *mr;
> > +	int ret;
> > +
> > +	rte_mempool_mem_iter(pool, mana_mempool_chunk_cb, ranges);
> > +
> > +	for (i = 0; i < pool->nb_mem_chunks; i++) {
> > +		if (ranges[i].len > priv->max_mr_size) {
> > +			DRV_LOG(ERR, "memory chunk size %u exceeding max
> MR\n",
> > +				ranges[i].len);
> > +			return -ENOMEM;
> 
> Did a quick search for extra newlines.
> Looks like this message will end up double spaced in log.
> DRV_LOG already adds a newline.

Yes, I will remove all extra spaces in other places as well.


More information about the dev mailing list