[PATCH V2] app/testpmd: fix display types failure when query RSS rule
Huisong Li
lihuisong at huawei.com
Fri Jul 8 03:41:59 CEST 2022
Now testpmd fails to display types when query RSS rule. The failure is
because the '\n' character is missing at the end of the function
'rss_config_display()'. Actually, all places calling 'xxx_types_display()'
need to '\n'. So this patch moves '\n' to the inside of these function.
Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output")
---
v2:
- move '\n' to the inside of 'xxx_types_display()'.
Signed-off-by: Huisong Li <lihuisong at huawei.com>
---
app/test-pmd/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 608bec9796..a2939867c4 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -761,6 +761,7 @@ rss_offload_types_display(uint64_t offload_types, uint16_t char_num_per_line)
total_len += str_len;
}
}
+ printf("\n");
}
void
@@ -870,7 +871,6 @@ port_infos_display(portid_t port_id)
printf("Supported RSS offload flow types:\n");
rss_offload_types_display(dev_info.flow_type_rss_offloads,
TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
- printf("\n");
}
printf("Minimum size of RX buffer: %u\n", dev_info.min_rx_bufsize);
@@ -1648,6 +1648,7 @@ rss_types_display(uint64_t rss_types, uint16_t char_num_per_line)
total_len += str_len;
}
}
+ printf("\n");
}
static void
@@ -3924,7 +3925,6 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key)
}
printf("RSS functions:\n");
rss_types_display(rss_hf, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
- printf("\n");
if (!show_rss_key)
return;
printf("RSS key:\n");
--
2.22.0
More information about the dev
mailing list