[PATCH v2] vhost/crypto: fix out of bound access

Fan Zhang roy.fan.zhang at intel.com
Fri Jul 8 15:59:14 CEST 2022


Coverity issue: 379211

Fixes: 4414bb67010d ("vhost/crypto: fix build with GCC 12")
Cc: david.marchand at redhat.com

Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com>
---
v2: 
  fix format-warning

 lib/vhost/vhost_crypto.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c
index 54946f46d9..bf899d2a50 100644
--- a/lib/vhost/vhost_crypto.c
+++ b/lib/vhost/vhost_crypto.c
@@ -574,12 +574,11 @@ copy_data_from_desc(void *dst, struct vhost_crypto_data_req *vc_req,
 
 	remain = RTE_MIN(desc->len, size);
 	addr = desc->addr;
-	do {
-		uint64_t len;
-		void *src;
 
-		len = remain;
-		src = IOVA_TO_VVA(void *, vc_req, addr, &len, VHOST_ACCESS_RO);
+	while (remain) {
+		uint64_t len = remain;
+		void *src = IOVA_TO_VVA(void *, vc_req, addr, &len, VHOST_ACCESS_RO);
+
 		if (unlikely(src == NULL || len == 0))
 			return 0;
 
@@ -588,7 +587,7 @@ copy_data_from_desc(void *dst, struct vhost_crypto_data_req *vc_req,
 		/* cast is needed for 32-bit architecture */
 		dst = RTE_PTR_ADD(dst, (size_t)len);
 		addr += len;
-	} while (unlikely(remain != 0));
+	}
 
 	return RTE_MIN(desc->len, size);
 }
-- 
2.34.1



More information about the dev mailing list